Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up downtime edit page by removing toggle and legacy edit endpoints #2188

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Tidy up downtime edit page by removing toggle and legacy edit endpoints #2188

merged 1 commit into from
Jun 4, 2024

Conversation

anatron
Copy link
Contributor

@anatron anatron commented May 29, 2024

Trello card

Task is to remove the toggle and legacy code created for the edit endpoint.

@mtaylorgds
Copy link
Contributor

I think we can delete app/assets/javascripts/legacy_modules/legacy_downtime_message.js (and its associated test) now.

mtaylorgds
mtaylorgds approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good—just a couple more files that I think we can also delete now (app/assets/javascripts/legacy_modules/legacy_downtime_message.js and its test).

@davidtrussler
Copy link
Contributor

@anatron @syed-ali-tw

  • Do we still need the styles in app/assets/stylesheets/downtime.scss? Looks to me like those might no longer used in the Design System update.
  • Also still needs the deletions Mark has referenced: app/assets/javascripts/legacy_modules/legacy_downtime_message.js & spec/javascripts/spec/legacy_downtime_message.spec.js

@anatron anatron force-pushed the tidy-edit-downtime branch from 5803448 to 6bb0c54 Compare June 4, 2024 08:25
@anatron anatron merged commit b83eec9 into main Jun 4, 2024
12 checks passed
@anatron anatron deleted the tidy-edit-downtime branch June 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaylorgds mtaylorgds mtaylorgds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anatron @mtaylorgds @davidtrussler